"Likes Received" layout issues and Like bug - ehMac.ca
Facebook
Twitter
YouTube
Register FAQ Members List Calendar Search Today's Posts Mark Forums Read


Reply
 
LinkBack Thread Tools Display Modes
Old Feb 14th, 2011, 04:38 PM   #1
mguertin
Guest
 
Posts: n/a
"Likes Received" layout issues and Like bug

I know this is a bit of a hot topic right now but ... the layout doesn't work so well, will probably get worse once things start to pile up in there. See attached screen snap. This is with Safari 5.0.3.

Also of note, when clicking the Like link the javascript that handles it should probably end in a "return false" so we don't get redirected back to the top of the page (due to it trying to load a blank hash link at the end of the url , i.e. "#").
Attached Images
File Type: png Screen shot 2011-02-14 at 4.33.45 PM.png (99.2 KB, 112 views)
  Reply With Quote
Sponsored Links
Advertisement
 
Old Feb 14th, 2011, 04:43 PM   #2
mguertin
Guest
 
Posts: n/a
Quote:
Originally Posted by mguertin View Post
Also of note, when clicking the Like link the javascript that handles it should probably end in a "return false" so we don't get redirected back to the top of the page (due to it trying to load a blank hash link at the end of the url , i.e. "#").
I retract this part of the bug, it already seems to be fixed
  Reply With Quote
Old Feb 14th, 2011, 04:46 PM   #3
Retired Mayor of ehMac
 
ehMax's Avatar
 
Join Date: Feb 2000
Location: ehMac World Headquarters
Posts: 10,150
Send a message via AIM to ehMax
Quote:
Originally Posted by mguertin View Post
I retract this part of the bug, it already seems to be fixed
I agree the layout in the member profile area is awful and needs to be changed.

The other one which I think will be the first thing, is ability to turn off notifications, or someway to modify that part.
__________________
Not a member of ehMac? Click here to join the community for Free!

Visit iCracked.com for Professional iPhone and iPad Repair!
ehMax is offline   Reply With Quote
Old Feb 14th, 2011, 05:28 PM   #4
mguertin
Guest
 
Posts: n/a
Quote:
Originally Posted by ehMax View Post
I agree the layout in the member profile area is awful and needs to be changed.

The other one which I think will be the first thing, is ability to turn off notifications, or someway to modify that part.
Yep that would be welcome

The issue with this particular layout is the HTML it is generating, if you look into it you'll see that it seems to have unmatched li tags within that area and is missing either ul or ol around them (which are likely what is causing the increasing indents). The layout issue would probably be the same in chrome and any other webkit based browser. It only seems to be an issue within the new Likes tab from what I can tell, but I didn't dig too heavily into it.
  Reply With Quote
Old Feb 14th, 2011, 05:38 PM   #5
mguertin
Guest
 
Posts: n/a
I take that back, they are enclosed by ol, but there are li tags and div tags not properly closed until the very end of all the code (i.e. all the </div> and </li> tags are at the very end. I highlighted the missing parts as well as the parent tags that they belong to in red within the code block for ease of explanation.

Here's the HTML in question from my profile:

ehMac.ca - View Profile: mguertin

Code:
<ol class="alt1 block_row list_no_decoration" id="likes_list">
	<li class="floatcontainer" id="like_1060852">
	
		<div class="fixed_width_avatar">
			<a href="http://www.ehmac.ca/members/krs.html" class="avatarlink"><img class="alt2 avatar" border="0" src="http://www.ehmac.ca/avatars/krs.gif?dateline=1154917840" alt="krs" width="60px" height="60px" title="krs"></a>
		</div>
		<div class="visitor_message_avatar_margin">
	
	<div class="tborder info_bar">
		<div class="alt2 smallfont">
			krs liked post by <a href="http://www.ehmac.ca/members/mguertin.html">mguertin</a> On thread : <strong>"Likes Received" layout issues and Like bug</strong>
		</div>
	</div>	
	<div class="visitor_message_body">
		<a href="http://www.ehmac.ca/info-centre/93037-likes-received-layout-issues-like-bug.html#post1060852">I know this is a bit of a hot topic right now but ... the layout doesn't work so well, will probably get worse once things start to pile up in there.  See attached screen snap.  This is with Safari...</a>
		<div class="smallfont">
			Liked On: Today, <span class="time">05:00 PM</span>
			<br>Posted On: Today, <span class="time">04:38 PM</span>
		</div>
	</div>
(missing </div> and </li> here)
<li class="floatcontainer" id="like_1060597">
	
		<div class="fixed_width_avatar">
			<a href="http://www.ehmac.ca/members/diveman.html" class="avatarlink"><img class="alt2 avatar" border="0" src="http://www.ehmac.ca/avatars/diveman.gif?dateline=1289918932" alt="diveman" width="60px" height="60px" title="diveman"></a>
		</div>
		<div class="visitor_message_avatar_margin">
	
	<div class="tborder info_bar">
		<div class="alt2 smallfont">
			diveman liked post by <a href="http://www.ehmac.ca/members/mguertin.html">mguertin</a> On thread : <strong>Vintage Traynor Speaker Identification</strong>
		</div>
	</div>	
	<div class="visitor_message_body">
		<a href="http://www.ehmac.ca/everything-else-eh/93012-vintage-traynor-speaker-identification.html#post1060597">For your usage as long as they don't sound too rough they would likely work out pretty well for you.  They might be a bit underpowered depending on the size of the room but bang for the buck they...</a>
		<div class="smallfont">
			Liked On: Today, <span class="time">04:26 PM</span>
			<br>Posted On: Yesterday, <span class="time">11:09 PM</span>
		</div>
	</div>
(missing </div> and </li> here)
	
<li class="floatcontainer" id="like_1060599">
	
		<div class="fixed_width_avatar">
			<a href="http://www.ehmac.ca/members/pm-r.html" class="avatarlink"><img class="alt2 avatar" border="0" src="http://www.ehmac.ca/avatars/pm-r.gif?dateline=1249413965" alt="pm-r" width="60px" height="60px" title="pm-r"></a>
		</div>
		<div class="visitor_message_avatar_margin">
	
	<div class="tborder info_bar">
		<div class="alt2 smallfont">
			pm-r liked post by <a href="http://www.ehmac.ca/members/mguertin.html">mguertin</a> On thread : <strong>mac repair in Sudbury, ON?</strong>
		</div>
	</div>	
	<div class="visitor_message_body">
		<a href="http://www.ehmac.ca/mac-ipod-help-troubleshooting/93019-mac-repair-sudbury-post1060599.html">Avoid North Star like the plague ... I had the misfortune of having to deal with them, and later having to clean up after them.  My last visit to their shop I stood un-noticed for a few minutes in...</a>
		<div class="smallfont">
			Liked On: Yesterday, <span class="time">11:27 PM</span>
			<br>Posted On: Yesterday, <span class="time">11:16 PM</span>
		</div>
	</div>
(missing </div> and </li> here)
	
<li class="floatcontainer" id="like_1060449">
	
		<div class="fixed_width_avatar">
			<a href="http://www.ehmac.ca/members/diveman.html" class="avatarlink"><img class="alt2 avatar" border="0" src="http://www.ehmac.ca/avatars/diveman.gif?dateline=1289918932" alt="diveman" width="60px" height="60px" title="diveman"></a>
		</div>
		<div class="visitor_message_avatar_margin">
	
	<div class="tborder info_bar">
		<div class="alt2 smallfont">
			diveman liked post by <a href="http://www.ehmac.ca/members/mguertin.html">mguertin</a> On thread : <strong>Vintage Traynor Speaker Identification</strong>
		</div>
	</div>	
	<div class="visitor_message_body">
		<a href="http://www.ehmac.ca/everything-else-eh/93012-vintage-traynor-speaker-identification.html#post1060449">L&amp;M would be the best place to get them identified for sure. Worst case they can pop them open and tell you at least what the components can handle power wise.  
 
Just guessing but they are probably...</a>
		<div class="smallfont">
			Liked On: Yesterday, <span class="time">02:59 PM</span>
			<br>Posted On: Yesterday, <span class="time">01:43 PM</span>
		</div>
	</div>
	
(missing </div> and </li> here)

(All the missing </div>'s and </li>'s are here)


</div>
</li></div></li></div></li></div></li></ol>
  Reply With Quote
Old Feb 14th, 2011, 05:46 PM   #6
mguertin
Guest
 
Posts: n/a
Also the Likes Received tab is missing unless you specifically follow a link that goes to that tab. If you just got to the main profile there is no Likes Received tab at all.

Was this a VB addon or something that someone worked up custom? Just curious.
  Reply With Quote
Old Feb 23rd, 2011, 01:13 PM   #7
mguertin
Guest
 
Posts: n/a
This could really use some attention ... it's to the point where things are getting unreadable ...
Attached Images
File Type: png Screen shot 2011-02-23 at 1.12.39 PM.png (18.7 KB, 89 views)
  Reply With Quote
Old Feb 23rd, 2011, 11:50 PM   #8
Retired Mayor of ehMac
 
ehMax's Avatar
 
Join Date: Feb 2000
Location: ehMac World Headquarters
Posts: 10,150
Send a message via AIM to ehMax
This will be fixed hopefully in the next couple of weeks.

----

Just wanted to mention one other thing about the like feature. There's a rumour floating around that I paid lots of money for this feature, and that's why I was holding onto it so tight.

Truth is, this feature was a completely free add-on to the software I already own for a long time called vBSEO. My tech just installed a free security update, and this feature was available in beta to try out. I saw it on several other forums that were trying it out, and well... I liked it.

There is an update to it coming out "Soon", which I'm hoping will address some of the bugs and annoyances. If it doesn't come out in the next couple of weeks, I will temporarily disable.
__________________
Not a member of ehMac? Click here to join the community for Free!

Visit iCracked.com for Professional iPhone and iPad Repair!
ehMax is offline   Reply With Quote
Old Feb 26th, 2011, 07:23 PM   #9
Outdated Citizen
 
The G3 Man's Avatar
 
Join Date: Oct 2008
Location: Canada
Posts: 937
Likes makes the site much more klunky.

+1 works much better

-MMF
__________________
[SIZE="1"]
MAIN: Early-08 MacBook Pro 15" 2.5ghz C2D
Mid-07 MacBook Pro 15" 2.4 C2D
PowerBook G3 "Pismo" 400mhz
iPhone 5 64gb Factory Unlocked
iPhone 4S 32GB Factory Unllocked
iPhone 4 16GB ROGERS
iPhone 3GS 32GB Unlocked by ROGERS

Apple Time Capsule 1G 500GB [/SIZE
The G3 Man is offline   Reply With Quote
Old Apr 22nd, 2011, 01:53 AM   #10
Honourable Citizen
 
cap10subtext's Avatar
 
Join Date: Oct 2005
Location: Toronto
Posts: 2,537
I like the likes, but the layout of the likes received page is now unreadable. So it would be great to get fixed.
cap10subtext is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off



All times are GMT -4. The time now is 10:57 AM.



Copyright © 1999 - 2012, ehMac.ca All rights reserved. ehMac is not affiliated with Apple Inc. Mac, iPod, iTunes, iPhone, Apple TV are trademarks of Apple Inc. Content Relevant URLs by vBSEO 3.6.0 RC 2

Tribe.ca: Urban living in Toronto!